Cleanup deadcode in preperation for k8s gogo changes #57883
+6
−424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/L
howardjohn
added
the
release-notes-none
Draft
See kubernetes/enhancements#5590 (comment); we use a lot of very questionable gogoproto on k8s type operations. The good news is, as far as I can every single one of these is on code paths that never actually touch k8s types (anymore), or are on entirely dead code paths. My plan is to split this into two PRs to make things simpler/safer. This PR removes strictly dead code that is in this area. There is a surprising amount here! I think this is as we moved more and more stuff away from these legacy `config.Config` paths towards kclient/krt the cruft just stayed around. In the next PRs I will remove the gogo proto handling (TBD how, if we want to fail or fallback). I've analyzed the remaining usages: ``` DeepCopy UpdateHealth, DeleteHealthCondition (WE only) mergeVirtualServicesIfNeeded (on VS spec) mergeDestinationRule mergeHTTPRoutes (its a VirtualService though, not a HTTPRoute) resolveVirtualServiceShortnames (on VS only) convertToWasmPluginWrapper (On WasmPlugin) In a bunch of tests ApplyJSON FromJSON ConvertObject webhook.validate (only called for istio types) ParseInputs (should be called for everything) kube/file.NewController Only allows Istio objects but I think its going to read all of them, so we couldn't panic or something? ApplyJSONStrict fromSchemaAndJSONMap validateResource (in istioctl, only used on Istio types) Equals() We already explicitly do not use gogoproto.Equals EXCEPT in `needsPush` which only operates on istio.io types ToProto(): PilotConfigToResource (I think this will only have Istio types) ToJSON(): ToRaw() ConvertConfig used in configz handler, which should only have Istio types ToPrettyJSON(): Not even used on protos, bug in xds/debug.go ```
howardjohn
force-pushed
the
dc/cleanup-gogo-proto
branch
from
f0ee51b to
743485f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
kubernetes/enhancements#5590 (comment); we use a lot of very questionable gogoproto on k8s type operations.
The good news is, as far as I can every single one of these is on code paths that never actually touch k8s types (anymore), or are on entirely dead code paths.
My plan is to split this into two PRs to make things simpler/safer.
This PR removes strictly dead code that is in this area. There is a surprising amount here! I think this is as we moved more and more stuff away from these legacy
config.Configpaths towards kclient/krt the cruft just stayed around.In the next PRs I will remove the gogo proto handling (TBD how, if we want to fail or fallback).
I've analyzed the remaining usages:
Please provide a description of this PR: