Skip to content

Conversation

DomixD
Copy link
Contributor

@DomixD DomixD commented Sep 9, 2025

Pull Request

Changes

  • Add aria attributes and roles
  • Add keyboard handling
  • Fix element highlighting and update sortablejs options

Reference

Issue: #MUXDBS-104

@DomixD DomixD requested a review from a team as a code owner September 9, 2025 07:46
Copy link
Contributor

coderabbitai bot commented Sep 9, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch MUXDBS-104-move-tasks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@DomixD DomixD requested a review from FabianWilms September 9, 2025 11:09
@FabianWilms
Copy link
Member

I can't get the sorting via keyboard to work locally - i tried to focus the element by tabbing to it, but the focus only reaches the checkbox.

What is the desired behaviour for the keyboard control?

@FabianWilms
Copy link
Member

It's working 👏

One minor detail: When I don't have a "selecteable" element selected and I press enter I would expect that nothing happens. Currently, when I press enter while highlighting a checked off entry for example, one random entry of the "open" list gets selected to be moved.

# Conflicts:
#	personalization-webcomponents/package-lock.json
#	personalization-webcomponents/package.json
@FabianWilms FabianWilms mentioned this pull request Sep 25, 2025
@FabianWilms FabianWilms self-assigned this Sep 25, 2025
@DomixD DomixD enabled auto-merge September 25, 2025 12:28
@DomixD DomixD merged commit 5324dd0 into main Sep 26, 2025
20 checks passed
@DomixD DomixD deleted the MUXDBS-104-move-tasks branch September 26, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants