-
Notifications
You must be signed in to change notification settings - Fork 5
feat(gateway): native image #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Relevant change from Spring 3.4 https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.4-Release-Notes#netty-in-native-image |
# Conflicts: # refarch-gateway/pom.xml # refarch-gateway/src/main/resources/application.yml
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
# Conflicts: # refarch-gateway/pom.xml
| tags: | | ||
| type=raw,value=dev-k8s | ||
| - name: Build with Maven | ||
| env: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only build image on main
|
Note: With Spring 3.5, this might be relevant: https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.5-Release-Notes#native-test-with-maven |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add release
| env: | ||
| IMAGE_NAME: ghcr.io/${{ github.repository }}/refarch-gateway-native | ||
| IMAGE_RAW_TAGS: ${{ steps.meta.outputs.tags }} | ||
| NATIVE_SPRING_PROFILES: hazelcast-k8s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add image for all profiles and document why (Profile can't be changed)
|
This could also be relevant from the Spring 3.5 release notes: - The |
|
This could also be relevant from the Spring 3.5 release notes: https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.5-Release-Notes#docker-config-authentication |
|
Following build error comes from podman server version below
|
# Conflicts: # refarch-gateway/pom.xml
Description
Add native image support to gateway.
References
Issues closes #29
it-at-m/appswitcher-server#27