-
Notifications
You must be signed in to change notification settings - Fork 5
docs(backend): keycloak permissions authorization via UMA #720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughDocumentation updated to replace Keycloak's custom plugin permissions approach with a Keycloak-specific UMA-based method. Permissions now retrieved from the OpenID token endpoint via UMA grant-type instead of authorities claim. Class reference updated from UserInfoAuthoritiesConverter to KeycloakPermissionsAuthoritiesConverter, enabling profile changed, and caching behavior noted. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/cross-cutting-concepts/security.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-maven
🔇 Additional comments (2)
docs/cross-cutting-concepts/security.md (2)
55-58: Clear and appropriate warning about UMA protocol limitation.The warning accurately conveys that UMA is Keycloak-specific and not universally supported, helping users make informed decisions about this approach.
66-68: Remove or correct the reference tokeycloak-permissionsprofile—it does not exist in the codebase.The Spring profile
keycloak-permissionsmentioned on line 67 is not defined anywhere in the Spring configuration or code. No profile-based conditional logic exists to enable permission-based authorization, and the current SecurityConfiguration only implements role-based authentication via oauth2ResourceServer without any mechanism to switch authorization models. Either remove this reference or document the actual profile name if such a feature is planned.Likely an incorrect or invalid review comment.
Pull Request
Changes
Reference
Issue: https://git.muenchen.de/ccse/refarch-security/-/issues/8
Checklist
Note: If some checklist items are not relevant for your PR, just remove them.
General
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.