736 fix location field error displayng#922
Merged
rusnakvlad merged 49 commits intodevelopmentfrom Dec 20, 2021
Merged
Conversation
rusnakvlad
changed the title
rusnakvlad
changed the title
added 9 commits
November 30, 2021 19:26
sand0
reviewed
Dec 12, 2021
sand0
reviewed
Dec 12, 2021
sand0
reviewed
Dec 12, 2021
sand0
reviewed
Dec 12, 2021
sand0
reviewed
Dec 12, 2021
sand0
reviewed
Dec 12, 2021
sand0
reviewed
Dec 12, 2021
sand0
reviewed
Dec 12, 2021
added 12 commits
December 15, 2021 19:41
iuriikhrystiuk
previously approved these changes
Dec 20, 2021
|
Kudos, SonarCloud Quality Gate passed! |
iuriikhrystiuk
approved these changes
Dec 20, 2021
sand0
approved these changes
Dec 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dev
GitHub Project
Code reviewers
Second Level Review
Summary of issue
The warning message of location validation was not displayed on the front, also the validation of location was not even happening on the back.
Summary of change
Was created location component which now handle logic of chousing location, also for location.onlineMeeting and location.Type we do not use any more component Field with property component, now is used directly the content which was passed to the property component of component Field. At the backend was refactored logic of location, so now we do not store in EventDto fields type, point and onlineMeeting, but only LocationDto. Also the type of onlineMeeting is not any more Uri, it was replaced by string.What about validation process, now the EventViewModel is validating directly in controller.
Testing approach
ToDo
CHECK LIST
#736