Skip to content

Fixed 500 status on eco news comments like/dislike#8412

Open
Andrii-Danylenko wants to merge 1 commit intodevfrom
fix/500-status-on-eco-news-like
Open

Fixed 500 status on eco news comments like/dislike#8412
Andrii-Danylenko wants to merge 1 commit intodevfrom
fix/500-status-on-eco-news-like

Conversation

@Andrii-Danylenko
Copy link
Member

@Andrii-Danylenko Andrii-Danylenko commented May 13, 2025

Summary
During testing, I came across a bug related to the presence of duplicates when trying to retrieve records from the database.

Changes
I cleared the database of duplicates and added primary key constraints on tables to prevent duplicates in the future.

Summary by CodeRabbit

  • Chores
    • Added primary key constraints to the comments_users_likes, comments_users_dislikes, and notifications_users tables to ensure uniqueness of user and comment/notification combinations.

@coderabbitai
Copy link

coderabbitai bot commented May 13, 2025

Walkthrough

This update introduces new Liquibase changesets that add composite primary key constraints to three database tables: comments_users_likes, comments_users_dislikes, and notifications_users. Each primary key is defined on two columns, ensuring the uniqueness of their combinations. No application code or public API entities are affected.

Changes

File(s) Change Summary
.../db/changelog/logs/ch-add-table-comments-users-likes-Fedotov.xml Added a Liquibase changeset to define a composite primary key (user_id, comment_id) on comments_users_likes.
.../db/changelog/logs/ch-comments-users-dislike-table.xml Added a Liquibase changeset to define a composite primary key (user_id, comment_id) on comments_users_dislikes.
.../db/changelog/logs/ch-add-table-notification-Mladonov.xml Added a Liquibase changeset to define a composite primary key (notification_id, user_id) on notifications_users.

Poem

Three tables now stand tall and proud,
With keys that join them in a crowd.
Uniqueness locked, collisions gone,
The schema sings a sturdy song.
Cheers to order, structure, might—
The database sleeps well tonight!
🗝️✨

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Andrii-Danylenko Andrii-Danylenko self-assigned this May 13, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (4)
dao/src/main/resources/db/changelog/logs/ch-comments-users-dislike-table.xml (1)

42-46: Align changeSet id naming convention

The id="1747141984482-1" format differs from other changeSets in this project (e.g., author-based or descriptive IDs). Consider adopting a consistent naming scheme—either a clear timestamp prefix or including the author—to maintain clarity and uniformity across your changelogs.

dao/src/main/resources/db/changelog/logs/ch-add-table-notification-Mladonov.xml (1)

34-38: Ensure proper rollback for schema change

Consider adding a <rollback> clause to drop the PK_notifications_users constraint. This keeps your changelog reversible and aligns with best practices for safe schema migrations.

dao/src/main/resources/db/changelog/logs/ch-add-table-comments-users-likes-Fedotov.xml (2)

55-59: Add rollback for primary key change

Including a <rollback> element to drop the PK_comments_users_likes constraint ensures that reversing this changeset cleanly removes the primary key, preserving reversibility in your migration pipeline.


55-59: Normalize changeSet id format

The id="1747142053687-1" deviates from descriptive or author-based IDs seen elsewhere. Harmonizing the ID pattern across all changeSets will improve readability and traceability of schema changes.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a68e4d1 and 23d302d.

📒 Files selected for processing (3)
  • dao/src/main/resources/db/changelog/logs/ch-add-table-comments-users-likes-Fedotov.xml (1 hunks)
  • dao/src/main/resources/db/changelog/logs/ch-add-table-notification-Mladonov.xml (1 hunks)
  • dao/src/main/resources/db/changelog/logs/ch-comments-users-dislike-table.xml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build

@sonarqubecloud
Copy link

Copy link
Contributor

@maks741 maks741 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you cannot simply edit already applied changelogs and exception about mismatching checksums will get thrown

@Andrii-Danylenko
Copy link
Member Author

I believe you cannot simply edit already applied changelogs and exception about mismatching checksums will get thrown

Why not? Changesets are like commits. They are applied to each file separately. LiquidBase tracks file changes.

@Andrii-Danylenko Andrii-Danylenko requested a review from maks741 May 13, 2025 15:31
Copy link
Contributor

@maks741 maks741 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed I was wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants