Skip to content

added ssh option 'keys_only: true' when not using password login issue #232 #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dnlmengs wants to merge 5 commits into
base: master
Choose a base branch
from
Open

added ssh option 'keys_only: true' when not using password login issue #232 #233

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6cae0fe
added ssh option 'keys_only: true' when not using password login
Nov 30, 2016
e64d525
fixed typo
Dec 1, 2016
3c74ee8
added requested condition 'Please set keys_only: true only if @option…
Dec 4, 2016
fb14b07
fixed typo
Dec 4, 2016
d929ec6
using opts hash instead of @options
Jan 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/itamae/backend.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,8 @@ def ssh_options
password = STDIN.noecho(&:gets).strip
print "\n"
opts.merge!(password: password)
else
opts.merge!(keys_only: true)
Copy link
Member

@ryotarai ryotarai Dec 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set keys_only: true only if @options[:key] is set.

Copy link
Author

@dnlmengs dnlmengs Dec 4, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @ryotarai, this is going to work when setting the key via command line but it is going to fail when the key is set by ssh config.
Is this the intended behaviour?

end

opts
Expand Down