Make _FloatN and _BitInt types as substitution candidates in mangling#159
Open
zsrkmyn wants to merge 1 commit intoitanium-cxx-abi:mainfrom
Open
Make _FloatN and _BitInt types as substitution candidates in mangling#159zsrkmyn wants to merge 1 commit intoitanium-cxx-abi:mainfrom
zsrkmyn wants to merge 1 commit intoitanium-cxx-abi:mainfrom
Conversation
As discussed in https://reviews.llvm.org/D140359, encodings of _FloatN and _BitInt(N) are relatively long, and thus should be treated as substitution candidates to shorten mangled names.
Collaborator
|
Substantively, this seems reasonable to me. |
Author
|
May I know if there's any concern on this? :-) |
Author
|
@rjmccall, can we get this checked in? Or is there anything else I should do? thanks! |
Collaborator
|
Sorry for losing track of this. Three comments:
|
|
FWIW, current clang substitutes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in https://reviews.llvm.org/D140359, encodings of _FloatN and _BitInt(N) are relatively long, and thus should be treated as substitution candidates to shorten mangled names.