Feature/enhance pipelines #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored `cd-release-preview.yml` and `cd-release.yml` to use a new reusable workflow, `cd-build-test-pack.yml`, for centralized build, test, and pack steps. This improves maintainability, reduces redundancy, and simplifies artifact handling. Key changes: - Introduced `cd-build-test-pack.yml` reusable workflow. - Replaced `build` jobs with `build-and-pack` in both workflows. - Simplified `publish` jobs to use artifact-based NuGet push. - Added `prepare` job in `cd-release.yml` for release notes handling. - Removed redundant steps for setting version, building, and packing. - Improved modularity by uploading and downloading artifacts between jobs.
Removed the `runner` input and hardcoded `ubuntu-latest` as the runner for the build job. Added a "Sanitize version" step to clean the `version` input by stripping leading `v` or `V`. Updated `dotnet build`, `dotnet test`, and `dotnet pack` to use the sanitized version. Upgraded `actions/checkout` and `actions/setup-dotnet` to `v4` for improved compatibility. Simplified workflow configuration by removing unused inputs.
Expanded CONTRIBUTING.md with detailed guidelines: - Added purpose and intent to help contributors avoid build issues. - Documented workflow reuse conventions with examples. - Defined versioning/tagging rules aligned with SemVer/NuGet. - Provided CI version sanitization steps and usage examples. - Included troubleshooting tips for common CI issues. - Emphasized maintenance alignment with GitHub Actions/NuGet.
Added a step to fetch the `origin/main` branch with a depth of 1 in the `cd-release.yml` workflow. Introduced a step to verify that the current commit exists in the `origin/main` branch by checking if the branch contains the commit. These changes ensure consistency and validate that the release process operates on a valid commit from the main branch.
Updated `cd-release.yml` to use `actions/checkout@v4` with `fetch-depth: 0` and modified the "Verify commit exists in origin/main" step. Updated `CryptoNet.sln` to reflect `VisualStudioVersion` 18.3.11222.16 and added a reference to the new workflow file `.github/workflows/cd-build-test-pack.yml` under the `DevOps` project section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.