Update support for iRODS #17341
Draft
Update support for iRODS #17341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korydraughn
commented
Aug 14, 2025
Comment on lines
+780
to
+791
| # iRODS configuration | ||
| # ------------------- | ||
| irods.client_negotiation_policy=CS_NEG_REFUSE | ||
| # Local files exceeding the following size will trigger use of parallel transfer. | ||
| # Normally defaults to 32MB in iRODS clients. | ||
| irods.parallel_transfer.size_threshold=33554432 | ||
| # The number of threads used for parallel transfer. | ||
| irods.parallel_transfer.thread_count=3 | ||
| # The size of the buffer used for reading during parallel transfer. | ||
| irods.parallel_transfer.rbuffer_size=4194304 | ||
| # The size of the buffer used for writing during parallel transfer. | ||
| irods.parallel_transfer.wbuffer_size=4194304 |
There was a problem hiding this comment.
Might drop these changes if there's a more appropriate location.
Comment on lines
+46
to
+48
| // TODO If we're dealing with a collection, should existing data objects sharing | ||
| // the same name be overwritten? This should probably be a configurable option. | ||
| IRODSFilesystem.copy(conn.getRcComm(), from, to, IRODSFilesystem.CopyOptions.RECURSIVE); |
Comment on lines
+61
to
63
| // TODO Shouldn't these be updated after the operation? | ||
| deleted.add(file); | ||
| callback.delete(file); |
Comment on lines
+93
to
+94
| // TODO Clamp the value so that users do not specify something ridiculous. | ||
| final int threadCount = 3; //preferences.getInteger("irods.parallel_transfer.thread_count"); |
Comment on lines
+168
to
+172
| // TODO Make this configurable. | ||
| executor.awaitTermination(5, TimeUnit.SECONDS); | ||
|
|
||
| // TODO Make this configurable. | ||
| final String fingerprintValue = IRODSFilesystem.dataObjectChecksum(primaryConn, logicalPath); |
Comment on lines
+26
to
+28
| // assertTrue(new IRODSExceptionMappingService().map(new CatNoAccessException("no access")) instanceof AccessDeniedException); | ||
| // assertTrue(new IRODSExceptionMappingService().map(new FileNotFoundException("no file")) instanceof NotfoundException); | ||
| // assertTrue(new IRODSExceptionMappingService().map(new AuthenticationException("no user")) instanceof LoginFailureException); |
There was a problem hiding this comment.
Restore once mapper is updated.
|
|
korydraughn
commented
Aug 14, 2025
|
|
||
| # iRODS configuration | ||
| # ------------------- | ||
| irods.client_negotiation_policy=CS_NEG_REFUSE |
There was a problem hiding this comment.
Expose iRODS options for secure communication and various other options.
|
@dkocher Can you provide the Entity CLA? |
Discussed in #14449 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates support for iRODS by replacing Jargon (legacy iRODS library) with irods4j.
The foundational work was implemented by @MINGYJ, a recent iRODS intern. My commits are mainly polish and corrections around the use of the irods4j library.
Basic functionality is working - i.e. single stream uploads/downloads, renames, editing, etc.
The parallel transfer implementation doesn't appear to be working as intended. This is likely due to not having a full understanding of how the Cyberduck components fit together - i.e. Read/WriteFeature vs Upload/DownloadFeature.
Here are the steps for performing parallel transfer (i.e. multipart uploads) in iRODS.
Putting in draft for now. Feedback and guidance on how to implement proper support for parallel transfer would be greatly appreciated.
Resolves #14449.