Skip to content

Conversation

@dkocher
Copy link
Contributor

@dkocher dkocher commented Nov 4, 2025

…ark.

@dkocher dkocher requested a review from a team as a code owner November 4, 2025 12:12
@dkocher dkocher marked this pull request as draft November 4, 2025 12:12
@sannies
Copy link

sannies commented Nov 5, 2025

look_at_preferences_all_the_time_parse_context_property_prevent_login_dialog_use_configure.patch

I believe this patch is neccessary.

  1. HostDictionary needs to parse it - otherwise it's not visible
  2. S3Session was not looking at/using the same value - fixed that inconsistency
  3. AWSSessionCredentialsRetriever uses url property directly to fetch credentials to workaround issue with Hostparser
  4. S3Protocol by-passes login dialogue when context is set (this one I'm not 100% sure if done correctly)

This change would help us a lot - it allows for a full integration of Cyberduck into some publishers' very manual processes when they deliver or retrieve content from Castlabs' software.

@dkocher
Copy link
Contributor Author

dkocher commented Nov 5, 2025

look_at_preferences_all_the_time_parse_context_property_prevent_login_dialog_use_configure.patch

I believe this patch is neccessary.

  1. HostDictionary needs to parse it - otherwise it's not visible
  2. S3Session was not looking at/using the same value - fixed that inconsistency
  3. AWSSessionCredentialsRetriever uses url property directly to fetch credentials to workaround issue with Hostparser
  4. S3Protocol by-passes login dialogue when context is set (this one I'm not 100% sure if done correctly)

This change would help us a lot - it allows for a full integration of Cyberduck into some publishers' very manual processes when they deliver or retrieve content from Castlabs' software.

Please open as a pull request to allow it to be commented.

@dkocher dkocher force-pushed the feature/GH-17612-context-property branch from 1a0d361 to a77ed26 Compare November 5, 2025 13:12
@dkocher dkocher added this to the 9.3 milestone Nov 5, 2025
@dkocher dkocher added the s3 AWS S3 Protocol Implementation label Nov 5, 2025
@dkocher dkocher force-pushed the feature/GH-17612-context-property branch 2 times, most recently from accd544 to c3534c9 Compare November 5, 2025 15:54
@dkocher dkocher requested a review from ylangisc November 5, 2025 16:23
@dkocher dkocher marked this pull request as ready for review November 5, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

s3 AWS S3 Protocol Implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants