Skip to content

Commit cd16a9d

Browse files
authored
Close setup webview when all actions have been completed (#2968)
1 parent 31dcd75 commit cd16a9d

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

extension/src/getStarted/webview/messages.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ export class WebviewMessages {
3838
return this.initializeProject()
3939
}
4040
if (message.type === MessageFromWebviewType.OPEN_EXPERIMENTS_WEBVIEW) {
41+
this.getWebview()?.dispose()
4142
return this.openExperiments()
4243
}
4344
Logger.error(`Unexpected message: ${JSON.stringify(message)}`)

extension/src/test/suite/getStarted/index.test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,8 @@ suite('GetStarted Test Suite', () => {
5757
type: MessageFromWebviewType.OPEN_EXPERIMENTS_WEBVIEW
5858
})
5959

60+
// eslint-disable-next-line @typescript-eslint/no-explicit-any
61+
expect((webview as any).disposer.disposed).to.be.true
6062
expect(mockOpenExperiments).to.be.calledOnce
6163
}).timeout(WEBVIEW_TEST_TIMEOUT)
6264

0 commit comments

Comments
 (0)