remove out of bound checking for the piecewise tendency

Author: SBlokhuizen

tests/tendencies/test_piecewise.py

@@ -107,6 +107,18 @@ def test_generate():
     assert not tendency.annotations
 
 
+def test_get_value_bounds():
+    """
+    Check the generated values outside of the time array.
+    """
+    tendency = PiecewiseLinearTendency(
+        user_time=np.array([1, 2, 3]), user_value=np.array([2, 4, 8])
+    )
+    _, values = tendency.get_value(np.array([0.0, 0.5, 1.0, 3.0, 3.5, 4.0]))
+    assert np.allclose(values, [2, 2, 2, 8, 8, 8])
+    assert not tendency.annotations
+
+
 def test_get_value_interpolate():
     """
     Check the generated interpolated values.
@@ -125,15 +137,15 @@ def test_get_value_interpolate():
     )
     time, values = tendency.get_value(np.array([0.5, 1.5, 2.0, 2.5, 3.0]))
     assert np.allclose(values, [2.0, 3.0, 4.0, 6.0, 8.0])
-    assert tendency.annotations
+    assert not tendency.annotations
 
     # Request after time range
     tendency = PiecewiseLinearTendency(
         user_time=np.array([1, 2, 3]), user_value=np.array([2, 4, 8])
     )
     time, values = tendency.get_value(np.array([1.0, 1.5, 2.0, 2.5, 3.5]))
     assert np.allclose(values, [2.0, 3.0, 4.0, 6.0, 8.0])
-    assert tendency.annotations
+    assert not tendency.annotations
 
 
 def test_get_derivative_interpolate():
@@ -159,7 +171,7 @@ def test_get_derivative_interpolate():
     )
     expected_derivatives = [2, 2, -1, -1, -0.5, -0.5, -0.5, -0.5, 2, 2, 2, 2, 2]
     assert np.allclose(derivatives, expected_derivatives)
-    assert tendency.annotations
+    assert not tendency.annotations
 
     # Request derivative after time range
     tendency = PiecewiseLinearTendency(
@@ -170,4 +182,4 @@ def test_get_derivative_interpolate():
     )
     expected_derivatives = [2, 2, -1, -1, -0.5, -0.5, -0.5, -0.5, 2, 2, 2, 2, 2]
     assert np.allclose(derivatives, expected_derivatives)
-    assert tendency.annotations
+    assert not tendency.annotations

waveform_editor/tendencies/piecewise.py

@@ -46,7 +46,6 @@ def get_value(
         if time is None:
             return self.time, self.value
 
-        self._validate_requested_time(time)
         interpolated_values = np.interp(time, self.time, self.value)
         return time, interpolated_values
 
@@ -59,7 +58,6 @@ def get_derivative(self, time: np.ndarray) -> np.ndarray:
         Returns:
             numpy array containing the derivatives
         """
-        self._validate_requested_time(time)
 
         # Compute piecewise derivatives
         dv = np.diff(self.value)
@@ -72,19 +70,6 @@ def get_derivative(self, time: np.ndarray) -> np.ndarray:
 
         return piecewise_derivatives[indices]
 
-    def _validate_requested_time(self, time):
-        """Check if the requested time data falls within the piecewise tendency.
-
-        Args:
-            time: The time array on which to generate points.
-        """
-        if np.any(time < self.time[0]) or np.any(time > self.time[-1]):
-            error_msg = (
-                f"The provided time array contains values outside the valid range "
-                f"({self.time[0]}, {self.time[-1]}).\n"
-            )
-            self.annotations.add(self.line_number, error_msg)
-
     def _validate_time_value(self, time, value):
         """Validates the provided time and value lists.