Merged
Conversation
SBlokhuizen
force-pushed
the
feature/nice-direct-mode
branch
from
3ed0290 to
fe54943
Compare
SBlokhuizen
requested review from
MireilleSchneider and
maarten-ic
as code owners
maarten-ic
reviewed
Sep 26, 2025
Collaborator
maarten-ic
left a comment
maarten-ic
left a comment
There was a problem hiding this comment.
Looks good! Some small comments, see below:
maarten-ic
reviewed
Sep 26, 2025
maarten-ic
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces support for running NICE in direct mode from the plasma shape editor. A new radio button allows switching between NICE inverse and direct modes. To use direct mode, the path to the NICE MUSCLE3 executable must be provided.
Coil currents from the most recent run are preserved, enabling a workflow where NICE is first run in inverse mode to estimate coil currents, followed by manual adjustments in direct mode for higher precision.
Note: NICE direct mode exhibits nondeterministic behavior. Repeated runs with identical settings do not always produce consistent results—starting from coil currents obtained via inverse mode may sometimes converge to the expected shape, but in other cases may fail to converge.