Option to store coil currents values in waveforms #127
Merged
SBlokhuizen merged 6 commits intodevelopfrom Sep 30, 2025
Merged
Conversation
SBlokhuizen
requested review from
MireilleSchneider and
maarten-ic
as code owners
maarten-ic
reviewed
Sep 29, 2025
maarten-ic
reviewed
Sep 29, 2025
waveform_editor/tendencies/base.py
Outdated
| def __init__(self, allow_zero_duration=False, **kwargs): | ||
| self.line_number = kwargs.pop("line_number", 0) | ||
| self.is_first_repeated = kwargs.pop("is_first_repeated", False) | ||
| self.allow_zero_duration = allow_zero_duration |
Collaborator
There was a problem hiding this comment.
allow_zero_duration is a class property, so we can just make this a class variable instead of an instance variable?
maarten-ic
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a button in the coil current option to store the current coil current values in waveforms, as piecewise linear tendencies.