Merged
Conversation
SBlokhuizen
force-pushed
the
docs/training
branch
from
8184610 to
5db64a9
Compare
SBlokhuizen
force-pushed
the
docs/training
branch
from
d9eec9a to
b4d4240
Compare
Collaborator
Author
|
This is ready for review, but CI fails due to issues mentioned in #133. @maarten-ic could you take a look at it and see if you have any comments? Thanks! |
maarten-ic
reviewed
Oct 31, 2025
Collaborator
maarten-ic
left a comment
maarten-ic
left a comment
There was a problem hiding this comment.
See comments below. Let me know if anything's unclear!
docs/source/training/training.rst
Outdated
|
|
||
| .. code-block:: bash | ||
|
|
||
| module load IMAS-Python SuiteSparse/7.7.0-intel-2023b libxml2 Blitz++ MUSCLE3 |
Collaborator
There was a problem hiding this comment.
Isn't IMAS-Python already loaded when loading the waveform-editor module?
Collaborator
Author
There was a problem hiding this comment.
True, but I was assuming that people would just pip install it, since we don't mention the module in the installation docs at all. If we do want people to use the module, we should ensure the module contains the latest version, and update the installation docs accordingly.
maarten-ic
reviewed
Nov 4, 2025
Collaborator
maarten-ic
left a comment
maarten-ic
left a comment
There was a problem hiding this comment.
Looks good, couple of typos left 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added waveform editor training material