Open
Conversation
SBlokhuizen
force-pushed
the
feature/nice-module
branch
from
dbf05d3 to
5da0db0
Compare
SBlokhuizen
requested review from
MireilleSchneider and
maarten-ic
as code owners
maarten-ic
approved these changes
Mar 30, 2026
Comment on lines
+29
to
+34
| default="nice_imas_inv_muscle3", | ||
| label="NICE inverse executable path", | ||
| doc="Path to NICE inverse IMAS MUSCLE3 executable", | ||
| ) | ||
| dir_executable = param.String( | ||
| default="nice_imas_dir_muscle3", |
Collaborator
There was a problem hiding this comment.
Beware that this has no effect for people that had already configured these settings.
Might be good to document somewhere that, in order to use the NICE executables from the module, users need to double-check which executables are used?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.