Closed
Conversation
maarten-ic
requested changes
Mar 10, 2025
Collaborator
maarten-ic
left a comment
There was a problem hiding this comment.
Let's first align how the export should work, see #29
Collaborator
Author
|
The functionality for exporting through a CLI is moved to #45 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this PR is build on top of the implementation of the WaveformExporter (#29)
This PR introduces a first draft for the CLI to call the exporter methods described in the WaveformExporter. The user can choose between 3 methods of determining the time arrays:
--num_interpis given, the waveform will be linearly interpolated between its start and end time, using this many points. For example, to generate the waveform using 5 points:waveform-editor export-ids ./test_yaml.yaml "imas:hdf5?path=./test_equilibrium#equilibrium/time_slice()/boundary/elongation" --num_interp 5--timesis provided, the user can point to a CSV file, containing the time steps, which are expected in a column-based format. For example, create atimes.csvcontaining:0 1 5 7 12 12.5 13 13.1 14These can then be provided using:
waveform-editor export-ids ./test_yaml.yaml "imas:hdf5?path=./test_equilibrium#equilibrium/time_slice()/boundary/elongation" --times times.csvNote: there are no tests for the CLI yet, these can be made once we settle on a syntax for it.