Skip to content

Commit 73fe3f5

Browse files
Remove deprecated TODOs
DEVSIX-4591 Autoported commit. Original commit hash: [de317ca693]
1 parent ec066b5 commit 73fe3f5

File tree

10 files changed

+1
-18
lines changed

10 files changed

+1
-18
lines changed

itext.tests/itext.svg.tests/itext/svg/converter/SvgConverterUnitTest.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,6 @@ public virtual void ResourceResolverInstanceTest() {
308308

309309
[NUnit.Framework.Test]
310310
public virtual void ResourceResolverInstanceCustomResolverTest() {
311-
//TODO DEVSIX-3814: remove in version 7.2
312311
DummySvgConverterProperties properties = new DummySvgConverterProperties();
313312
SvgConverterUnitTest.TestSvgProcessorResult testSvgProcessorResult = new SvgConverterUnitTest.TestSvgProcessorResult
314313
(this);
@@ -318,14 +317,12 @@ public virtual void ResourceResolverInstanceCustomResolverTest() {
318317

319318
[NUnit.Framework.Test]
320319
public virtual void ResourceResolverInstanceCustomResolverNullPropsTest() {
321-
//TODO DEVSIX-3814: remove in version 7.2
322320
SvgConverterUnitTest.TestSvgProcessorResult testSvgProcessorResult = new SvgConverterUnitTest.TestSvgProcessorResult
323321
(this);
324322
ResourceResolver currentResolver = SvgConverter.GetResourceResolver(testSvgProcessorResult, null);
325323
NUnit.Framework.Assert.IsNotNull(currentResolver);
326324
}
327325

328-
//TODO DEVSIX-3814: remove in version 7.2
329326
internal class TestSvgProcessorResult : ISvgProcessorResult {
330327
public TestSvgProcessorResult(SvgConverterUnitTest _enclosing) {
331328
this._enclosing = _enclosing;

itext/itext.io/itext/io/font/otf/ContextualSubTable.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,10 @@ protected internal ContextualSubTable(OpenTypeFontTableReader openReader, int lo
4848
}
4949

5050
public override ContextualSubstRule GetMatchingContextRule(GlyphLine line) {
51-
// TODO DEVSIX-3814 Remove this dummy override. It's left only for binary backwards compatibility
5251
return base.GetMatchingContextRule(line);
5352
}
5453

5554
protected internal override int CheckIfContextMatch(GlyphLine line, ContextualSubstRule rule) {
56-
// TODO DEVSIX-3814 Remove this dummy override. It's left only for binary backwards compatibility
5755
return base.CheckIfContextMatch(line, rule);
5856
}
5957
}

itext/itext.svg/itext/svg/converter/SvgConverter.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1402,14 +1402,11 @@ internal static ResourceResolver GetResourceResolver(ISvgProcessorResult process
14021402
props) {
14031403
ResourceResolver resourceResolver = null;
14041404
if (processorResult is SvgProcessorResult) {
1405-
//TODO DEVSIX-3814 add assert after 7.2 cause now be have a null pointer on deprecated constructor
14061405
SvgProcessorContext context = ((SvgProcessorResult)processorResult).GetContext();
14071406
if (context != null) {
14081407
resourceResolver = context.GetResourceResolver();
14091408
}
14101409
}
1411-
//TODO DEVSIX-3814 remove the clause when the deprecated constructor SvgProcessorResult(Map<String, ISvgNodeRenderer>,
1412-
// ISvgNodeRenderer, FontProvider, FontSet) is removed
14131410
if (resourceResolver == null) {
14141411
resourceResolver = iText.Svg.Converter.SvgConverter.CreateResourceResolver(props);
14151412
}
@@ -1434,8 +1431,6 @@ private static ResourceResolver CreateResourceResolver(ISvgConverterProperties p
14341431
if (props == null) {
14351432
return new ResourceResolver(null);
14361433
}
1437-
// TODO DEVSIX-3814 change the clause if-else to return new ResourceResolver(props.getBaseUri(),
1438-
// props.getResourceRetriever()) when the ISvgConverterProperties#getResourceRetriever() is added
14391434
if (props is SvgConverterProperties) {
14401435
return new ResourceResolver(props.GetBaseUri(), ((SvgConverterProperties)props).GetResourceRetriever());
14411436
}

itext/itext.svg/itext/svg/processors/impl/SvgProcessorContext.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,6 @@ public SvgProcessorContext(ISvgConverterProperties converterProperties) {
8686
fontProvider = new BasicFontProvider();
8787
}
8888
IResourceRetriever retriever = null;
89-
// TODO DEVSIX-3814 change the clause if block to retriever = new ResourceResolver(props.getBaseUri(),
90-
// converterProperties.getResourceRetriever()) when the ISvgConverterProperties#getResourceRetriever() is added
9189
if (converterProperties is SvgConverterProperties) {
9290
retriever = ((SvgConverterProperties)converterProperties).GetResourceRetriever();
9391
}

itext/itext.svg/itext/svg/renderers/impl/AbstractSvgNodeRenderer.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,6 @@ protected internal virtual void DeepCopyAttributesAndStyles(ISvgNodeRenderer dee
205205
/// </returns>
206206
[Obsolete]
207207
protected internal virtual Rectangle GetObjectBoundingBox(SvgDrawContext context) {
208-
// TODO DEVSIX-3814 move to ISvgNodeRenderer in 7.2
209208
return null;
210209
}
211210

itext/itext.svg/itext/svg/renderers/impl/ISvgTextNodeHelper.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,5 @@ public interface ISvgTextNodeHelper {
4545
/// <see cref="iText.Svg.Utils.TextRectangle"/>
4646
/// </returns>
4747
TextRectangle GetTextRectangle(SvgDrawContext context, Point basePoint);
48-
// TODO DEVSIX-3814 This method should be moved to ISvgTextNodeRenderer in 7.2 and this class should be removed
4948
}
5049
}

itext/itext.svg/itext/svg/renderers/impl/PathSvgNodeRenderer.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,6 @@ protected internal override Rectangle GetObjectBoundingBox(SvgDrawContext contex
146146
if (lastPoint == null) {
147147
lastPoint = item.GetEndingPoint();
148148
}
149-
// TODO DEVSIX-3814 - remove this check after moving method getPathShapeRectangle to IPathShape
150149
if (item is AbstractPathShape) {
151150
Rectangle rectangle = ((AbstractPathShape)item).GetPathShapeRectangle(lastPoint);
152151
commonRectangle = Rectangle.GetCommonRectangle(commonRectangle, rectangle);

itext/itext.svg/itext/svg/renderers/impl/TextSvgTSpanBranchRenderer.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ public TextSvgTSpanBranchRenderer() {
5050
}
5151

5252
protected internal override Rectangle GetObjectBoundingBox(SvgDrawContext context) {
53-
// TODO DEVSIX-3814 change to getParent().getObjectBoundingBox(context) in 7.2 update
5453
if (GetParent() is AbstractSvgNodeRenderer) {
5554
return ((AbstractSvgNodeRenderer)GetParent()).GetObjectBoundingBox(context);
5655
}

itext/itext.svg/itext/svg/renderers/path/impl/AbstractPathShape.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ public virtual Point GetEndingPoint() {
9191
/// <param name="lastPoint">start point for this shape</param>
9292
/// <returns>calculated rectangle</returns>
9393
public virtual Rectangle GetPathShapeRectangle(Point lastPoint) {
94-
// TODO DEVSIX-3814 - add method declaration into IPathShape and remove here in iText 7.2
9594
return new Rectangle((float)CssUtils.ConvertPxToPts(GetEndingPoint().GetX()), (float)CssUtils.ConvertPxToPts
9695
(GetEndingPoint().GetY()), 0, 0);
9796
}

port-hash

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1a88e77a3ad86d8caa576b20ef41863b293f6403
1+
de317ca693a02b51737e5317a139241186f40341

0 commit comments

Comments
 (0)