Set color on font when drawing a TextField with MaxLen

Regenerate field when MaxLen status is changed

DEVSIX-2751

Author: LodrKumquat

forms/src/main/java/com/itextpdf/forms/fields/PdfFormField.java

@@ -90,6 +90,7 @@ This file is part of the iText (R) project.
 import com.itextpdf.layout.property.Leading;
 import com.itextpdf.layout.property.Property;
 import com.itextpdf.layout.property.TextAlignment;
+import com.itextpdf.layout.property.TransparentColor;
 import com.itextpdf.layout.property.VerticalAlignment;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -1486,7 +1487,12 @@ public boolean isPassword() {
      * @return the edited field
      */
     public PdfFormField setFieldFlags(int flags) {
-        return put(PdfName.Ff, new PdfNumber(flags));
+        int oldFlags = getFieldFlags();
+        put(PdfName.Ff, new PdfNumber(flags));
+        if (((oldFlags ^ flags) & PdfTextFormField.FF_COMB) != 0
+                && PdfName.Tx.equals(getFormType()) && new PdfTextFormField(getPdfObject()).getMaxLen() != 0)
+            regenerateField();
+        return this;
     }
 
     /**
@@ -2865,6 +2871,8 @@ protected void drawTextAppearance(Rectangle rect, PdfFont font, float fontSize,
 
         Style paragraphStyle = new Style().setFont(font).setFontSize(fontSize);
         paragraphStyle.setProperty(Property.LEADING, new Leading(Leading.MULTIPLIED, 1));
+        if (color != null)
+            paragraphStyle.setProperty(Property.FONT_COLOR, new TransparentColor(color));
 
         int maxLen = new PdfTextFormField(getPdfObject()).getMaxLen();
         // check if /Comb has been set
@@ -2886,18 +2894,15 @@ protected void drawTextAppearance(Rectangle rect, PdfFont font, float fontSize,
             float startOffset = widthPerCharacter * (start + 0.5f);
             for (int i = 0; i < numberOfCharacters; i++) {
                 modelCanvas.showTextAligned(new Paragraph(value.substring(i, i+1)).addStyle(paragraphStyle),
-                         startOffset + widthPerCharacter * i, rect.getHeight() / 2, TextAlignment.CENTER, VerticalAlignment.MIDDLE);
+                        startOffset + widthPerCharacter * i, rect.getHeight() / 2, TextAlignment.CENTER, VerticalAlignment.MIDDLE);
             }
         } else {
             if (this.getFieldFlag(PdfTextFormField.FF_COMB)) {
                 Logger logger = LoggerFactory.getLogger(PdfFormField.class);
                 logger.error(MessageFormatUtil.format(LogMessageConstant.COMB_FLAG_MAY_BE_SET_ONLY_IF_MAXLEN_IS_PRESENT));
             }
-            Paragraph paragraph = new Paragraph(value).addStyle(paragraphStyle).setPaddings(0, X_OFFSET, 0, X_OFFSET);
-            if (color != null) {
-                paragraph.setFontColor(color);
-            }
-            modelCanvas.showTextAligned(paragraph, x, rect.getHeight() / 2, textAlignment, VerticalAlignment.MIDDLE);
+            modelCanvas.showTextAligned(new Paragraph(value).addStyle(paragraphStyle).setPaddings(0, X_OFFSET, 0, X_OFFSET),
+                    x, rect.getHeight() / 2, textAlignment, VerticalAlignment.MIDDLE);
         }
         canvas.
                 restoreState().

forms/src/main/java/com/itextpdf/forms/fields/PdfTextFormField.java

@@ -221,11 +221,14 @@ public int getMaxLen() {
     }
 
     /**
-     * Sets the maximum length of the field?s text, in characters.
+     * Sets the maximum length of the field's text, in characters.
      * @param maxLen the maximum text length
      * @return current
      */
     public PdfTextFormField setMaxLen(int maxLen) {
-        return (PdfTextFormField) put(PdfName.MaxLen, new PdfNumber(maxLen));
+        put(PdfName.MaxLen, new PdfNumber(maxLen));
+        if (getFieldFlag(FF_COMB))
+            regenerateField();
+        return this;
     }
 }

forms/src/test/java/com/itextpdf/forms/PdfFormFieldTest.java

@@ -841,4 +841,50 @@ public void maxLenDeepInheritanceTest() throws IOException, InterruptedException
 
         Assert.assertNull(new CompareTool().compareByContent(destFilename, cmpFilename, destinationFolder, "diff_"));
     }
+
+    @Test
+    public void maxLenColoredTest() throws IOException, InterruptedException {
+        String srcPdf = sourceFolder + "maxLenColoredTest.pdf";
+        String outPdf = destinationFolder + "maxLenColoredTest.pdf";
+        String cmpPdf = sourceFolder + "cmp_maxLenColoredTest.pdf";
+
+        PdfDocument pdfDoc = new PdfDocument(new PdfReader(srcPdf), new PdfWriter(outPdf));
+        PdfAcroForm form = PdfAcroForm.getAcroForm(pdfDoc, false);
+        form.getField("magenta").setColor(ColorConstants.MAGENTA);
+
+        pdfDoc.close();
+
+        CompareTool compareTool = new CompareTool();
+        String errorMessage = compareTool.compareByContent(outPdf, cmpPdf, destinationFolder, "diff_");
+        if (errorMessage != null) {
+            Assert.fail(errorMessage);
+        }
+    }
+
+    @Test
+    @LogMessages(messages = {@LogMessage(messageTemplate = LogMessageConstant.COMB_FLAG_MAY_BE_SET_ONLY_IF_MAXLEN_IS_PRESENT, count = 2)})
+    public void regenerateMaxLenCombTest() throws IOException, InterruptedException {
+        String srcPdf = sourceFolder + "regenerateMaxLenCombTest.pdf";
+        String outPdf = destinationFolder + "regenerateMaxLenCombTest.pdf";
+        String cmpPdf = sourceFolder + "cmp_regenerateMaxLenCombTest.pdf";
+
+        PdfDocument pdfDoc = new PdfDocument(new PdfReader(srcPdf), new PdfWriter(outPdf));
+        PdfAcroForm form = PdfAcroForm.getAcroForm(pdfDoc, true);
+
+        for (int i = 0; i < 12; i++) {
+            PdfTextFormField field = (PdfTextFormField) form.getField("field " + i);
+            if (i < 8)
+                field.setMaxLen(i < 4 ? 7 : 0);
+            if (i % 6 > 1)
+                field.setFieldFlag(PdfTextFormField.FF_COMB, i % 2 == 0 ? true : false);
+
+        }
+        pdfDoc.close();
+
+        CompareTool compareTool = new CompareTool();
+        String errorMessage = compareTool.compareByContent(outPdf, cmpPdf, destinationFolder, "diff_");
+        if (errorMessage != null) {
+            Assert.fail(errorMessage);
+        }
+    }
 }