Pull Request to create/update 'rebased/structure-tree-fix' branch#315
Closed
Pull Request to create/update 'rebased/structure-tree-fix' branch#315
Conversation
`/Type /StructElem` is optional for structure element nodes, but if it wasn't present, we weren't checking the /S key for better node titles. Now it will assume /StructElem type, if type is missing. Also, there was some weird thing with the caption having NUL characters, as toUnicodeString was returning them. Not sure, whether they are present in the PDF itself or is it just some other random issue. For now just added stripping for some of the ASCII control chars.
240af17 to
909b085
Compare
I've managed to find such files in the wild. There is a proper page in the page tree. But the structure elements reference some entirely different page, which is not referenced in /Pages... Now in such cases we will assume, that no marked content was found.
909b085 to
4d4130a
Compare
michaeldemey
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Programmatically created Pull Request to automatically keep merge branch to develop up-to-date