Conversation
…ns, reduced url keys to 32 Characters for performance and easy copy and paste and compatibility while still mainitaining ubreakable cryptographic keys
…ut will not let them continue, also update some wording and button colors. Also dont show email password fields again after success and login as agent and client is shown.
… is a certain width on the desktop
…ting page. This will have a major query speed and memory optimization impact
…ory optimization. Add title for List View and Grid View
…tore functions to files
Ticket task approvals
… a v2, delete old and rename once we're happy)
- Keep the selected view (kanban/list) when applying other filters - Allow filtering tickets by project (main and kanban v2)
- Keep the selected view (kanban/list) when applying other filters - Allow filtering tickets by project (main and kanban v2)
…ge rename var from important to favorite
…n role add nice blocker style radios buttons instead of select boxes
My bad, my changes were made previously using my installed version and not the latest changes in the dev branch, i have pulled the dev branch and merged my changes with the latest codebase.
My bad, my changes were made previously using my installed version and not the latest changes in the dev branch, i have pulled the dev branch and merged my changes with the latest codebase.
Rename multiple functions to conform to project naming rules (^[a-z][a-zA-Z0-9]*$). This is a non-functional refactor for style/CI compliance and consistency.
Removed two instances of unecessary double parentheses.
Defined a constant $settings_mail_path at the top of the file instead of duplicating "/admin/settings_mail.php" in the code multiple times.
Define a constant "MICROSOFT_OAUTH_BASE_URL" instead of duplicating "https://login.microsoftonline.com/" multiple times in the same file.
Remove duplicates of https://login.microsoftonline.com/ and make them use a constant.
Accidentally comitted an older file.
Add full Microsoft 365 and Google OAuth mail support
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+15
to
+21
| $sql_merge = mysqli_query($mysqli, "SELECT * FROM tickets | ||
| LEFT JOIN ticket_statuses ON ticket_status = ticket_status_id | ||
| LEFT JOIN clients ON client_id = ticket_client_id | ||
| WHERE ticket_closed_at IS NULL | ||
| $whereNotIn | ||
| ORDER BY ticket_status ASC, ticket_id DESC" | ||
| ); |
Check failure
Code scanning / SonarCloud
Database queries should not be vulnerable to injection attacks
|
|
||
| // Move document | ||
| mysqli_query($mysqli,"UPDATE documents SET document_folder_id = $folder_id WHERE document_id = $document_id"); | ||
| mysqli_query($mysqli,"UPDATE documents SET document_folder_id = $folder_id, document_updated_at = document_updated_at WHERE document_id = $document_id"); |
Check failure
Code scanning / SonarCloud
Database queries should not be vulnerable to injection attacks
wrongecho
requested changes
Feb 6, 2026
Collaborator
wrongecho
left a comment
wrongecho
left a comment
There was a problem hiding this comment.
Oauth code has reverted other changes.
Collaborator
Author
|
Cancelling to investigate code overlaps from the oauth2 merge |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Develop to Master for 26.02 release