feat: stache content pipe #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeoIsRecursive
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a pipe to automatically determine content locations, replacing the manual configuration of the content_path.
- Added a YAML fixture for a submission with sample text content.
- Added a YAML fixture for pages to support the new content detection mechanism.
Reviewed Changes
Copilot reviewed 4 out of 16 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/fixtures/content/submissions/1743066599.5568.yaml | New submission fixture with sample text content. |
| tests/fixtures/content/collections/pages.yaml | New fixture for pages defining a title and template as part of the new content system. |
Files not reviewed (12)
- config/backup.php: Language not supported
- phpunit.xml: Language not supported
- src/Pipes/Content.php: Language not supported
- src/Pipes/ContentStachePipe.php: Language not supported
- tests/Feature/RestoreBackupTest.php: Language not supported
- tests/Helpers.php: Language not supported
- tests/TestCase.php: Language not supported
- tests/Unit/BackuperTest.php: Language not supported
- tests/Unit/ChunkyTest.php: Language not supported
- tests/Unit/PipeTest.php: Language not supported
- tests/Unit/RestorerTest.php: Language not supported
- tests/Unit/ZipperTest.php: Language not supported
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the new StacheData pipe to replace the existing Content pipe, improving the automated resolution of content paths and reducing configuration overhead.
- Updated fixture data for pages in tests.
- Revised documentation in pipeline.md to reference the new StacheData pipe.
- Modified the Logs backup and restore method signatures, including adding readonly to the Logs class.
Reviewed Changes
Copilot reviewed 5 out of 21 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/fixtures/content/collections/pages.yaml | Adds fixture data for pages to support content backup testing. |
| docs/pages/pipeline.md | Updates pipeline examples and adjusts method signatures in Logs. |
Files not reviewed (16)
- config/backup.php: Language not supported
- phpunit.xml: Language not supported
- src/Abstracts/BackupPipe.php: Language not supported
- src/Pipes/Assets.php: Language not supported
- src/Pipes/Content.php: Language not supported
- src/Pipes/StacheData.php: Language not supported
- src/Pipes/Users.php: Language not supported
- tests/Feature/RestoreBackupTest.php: Language not supported
- tests/Helpers.php: Language not supported
- tests/SkippingPipe.php: Language not supported
- tests/TestCase.php: Language not supported
- tests/Unit/BackuperTest.php: Language not supported
- tests/Unit/ChunkyTest.php: Language not supported
- tests/Unit/PipeTest.php: Language not supported
- tests/Unit/RestorerTest.php: Language not supported
- tests/Unit/ZipperTest.php: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a pipe that is intended to supersede
Itiden\Backup\Pipes\Content.This pipe will know where your content is so users wont have to configure it. And we can remove the
content_pathconfig value.content_path...