Skip to content

Feature/small design fixes #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Feature/small design fixes #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e27d630
Set black background when dark mode
yepzdk Dec 20, 2024
02dbe69
center content in desktop view
yepzdk Dec 20, 2024
0730d73
Change color to white
yepzdk Dec 20, 2024
befd6aa
Include index.html for discovering classes
yepzdk Dec 20, 2024
965cb09
Update CHANGELOG.md
yepzdk Dec 20, 2024
83db17d
Apply with prettier
yepzdk Dec 20, 2024
a2f558f
Merge branch 'develop' into feature/small-design-fixes
yepzdk Dec 20, 2024
2f897d1
Update App.jsx
yepzdk Dec 20, 2024
fc8bfc6
Update App.jsx
yepzdk Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

- [PR-64](https://github.com/itk-dev/aapodwalk/pull/64)
- Clean up some rough edges in the design

- [PR-63](https://github.com/itk-dev/aapodwalk/pull/63)
- react 18 -> [react 19](https://react.dev/blog/2024/12/05/react-19)
- react-dom 18 -> 19
Expand Down
2 changes: 1 addition & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Podwalk</title>
</head>
<body class="dark dark:text-white text-black">
<body class="dark dark:text-white dark:bg-black text-black bg-white">
<div id="root"></div>
<script type="module" src="/src/index.jsx"></script>
</body>
Expand Down
5 changes: 2 additions & 3 deletions src/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React, { useEffect, useState, useMemo } from "react";
import { Switch, Route } from "react-router-dom";
import { Switch, Route, Link } from "react-router-dom";
import LatLongContext from "./context/latitude-longitude-context";
import PermissionContext from "./context/permission-context";
import RouteContext from "./context/RouteContext";
Expand All @@ -13,7 +13,6 @@ import SkipLinks from "./components/SkipLinks";
import FAQ from "./components/FAQ";
import SeeOnMap from "./components/SeeOnMap";
import MessageContext from "./context/MessageContext";
import { Link } from "react-router-dom";
import NavigationHelp from "./components/NavigationHelp";
import MapConsentBanner from "./components/MapConsentBanner";

Expand Down Expand Up @@ -93,7 +92,7 @@ function App() {
}, [openStreetMapConsent]);

return (
<div className="App flex flex-col h-full pt-24 min-h-screen dark:text-white w-screen pl-3 pr-3 pb-3 text-zinc-800 bg-zinc-100 dark:bg-zinc-800 overflow-hidden">
<div className="App md:max-w-4xl ml-auto mr-auto flex flex-col h-full pt-24 min-h-screen dark:text-white w-screen pl-3 pr-3 pb-3 text-zinc-800 bg-zinc-100 dark:bg-zinc-800 overflow-hidden">
<LatLongContext value={contextLatLong}>
<PermissionContext
value={useMemo(() => ({ openStreetMapConsent, setOpenStreetMapConsent }), [openStreetMapConsent])}
Expand Down
2 changes: 1 addition & 1 deletion src/components/Navbar.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const Navbar = () => {
const { pathname } = useLocation();

return (
<nav className="fixed top-0 left-0 right-0 p-3 bg-zinc-100 dark:bg-zinc-800 z-50">
<nav className="md:max-w-4xl ml-auto mr-auto fixed top-0 left-0 right-0 p-3 bg-zinc-100 dark:bg-zinc-800 z-50">
<div className="mb-6 mt-4 flex justify-between">
{pathname === "/" && (
<Link to="/">
Expand Down
4 changes: 2 additions & 2 deletions src/icons/xmark-solid.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tailwind.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/** @type {import('tailwindcss').Config} */
module.exports = {
content: ["./src/**/*.{js,jsx,ts,tsx}"],
content: ["./src/**/*.{js,jsx,ts,tsx}", "./index.html"],
theme: {
extend: {},
},
Expand Down
Loading