-
Notifications
You must be signed in to change notification settings - Fork 1
Added hoeringsportal_anonymous_edit module #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
90f1f9e to
54d3d3a
Compare
54d3d3a to
a6afc97
Compare
| * {@inheritdoc} | ||
| */ | ||
| public function submitForm(array &$form, FormStateInterface $form_state): void { | ||
| // Everything has been done in validateForm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? It seems counter intuitive? What if a later validate hook/event causes a validation error? I know it's theoretical.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
This looks great! I was wondering - on
|
0026ea9 to
aeb0b7a
Compare
# Conflicts: # web/modules/custom/hoeringsportal_dialogue/hoeringsportal_dialogue.info.yml
aeb0b7a to
d864868
Compare
Link to ticket
https://leantime.itkdev.dk/_#/tickets/showTicket/6051
Description
Please see web/modules/custom/hoeringsportal_anonymous_edit/README.md for a description of what's going on.
Some things that must be addressed
/hoeringsportal-anonymous-edit/contentcould be/my/content, say.The failing “Load fixtures” check is resolved by the changes in #565.
Screenshot of the result
/hoeringsportal-anonymous-edit/content(user has no edit token):/hoeringsportal-anonymous-edit/content/request:/hoeringsportal-anonymous-edit/content/recover/{token}:Back on
/hoeringsportal-anonymous-edit/content(user now has an edit token):Checklist
If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.
Additional comments or questions
If you have any further comments or questions for the reviewer please add them here.