Skip to content

Conversation

@rimi-itk
Copy link
Contributor

@rimi-itk rimi-itk commented Nov 21, 2025

Link to ticket

https://leantime.itkdev.dk/_#/tickets/showTicket/6051

Description

Please see web/modules/custom/hoeringsportal_anonymous_edit/README.md for a description of what's going on.

Some things that must be addressed

  • Does a user “recover” or “restore” an edit token?
  • Better paths, e.g. /hoeringsportal-anonymous-edit/content could be /my/content, say.

The failing “Load fixtures” check is resolved by the changes in #565.

Screenshot of the result

/hoeringsportal-anonymous-edit/content (user has no edit token):

Screenshot 2025-11-21 at 10 31 50

/hoeringsportal-anonymous-edit/content/request:

Screenshot 2025-11-21 at 10 32 01

/hoeringsportal-anonymous-edit/content/recover/{token}:

Screenshot 2025-11-21 at 10 32 36 Screenshot 2025-11-21 at 10 32 26 Screenshot 2025-11-21 at 10 32 32

Back on /hoeringsportal-anonymous-edit/content (user now has an edit token):

Screenshot 2025-11-21 at 10 32 41

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

If you have any further comments or questions for the reviewer please add them here.

@rimi-itk rimi-itk force-pushed the feature/anonymous-edit branch from 90f1f9e to 54d3d3a Compare November 21, 2025 10:12
@rimi-itk rimi-itk changed the title Added hoeringsportal_anonymous_edit module WIP: Added hoeringsportal_anonymous_edit module Nov 21, 2025
@rimi-itk rimi-itk force-pushed the feature/anonymous-edit branch from 54d3d3a to a6afc97 Compare November 21, 2025 10:31
@rimi-itk rimi-itk requested a review from martinyde November 21, 2025 11:45
* {@inheritdoc}
*/
public function submitForm(array &$form, FormStateInterface $form_state): void {
// Everything has been done in validateForm.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? It seems counter intuitive? What if a later validate hook/event causes a validation error? I know it's theoretical.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yepzdk
Copy link
Contributor

yepzdk commented Nov 21, 2025

This looks great!

I was wondering - on /hoeringsportal-anonymous-edit/content can we add info about:

  • Which Dialog (Maybe other content types in the future) the comment belongs to?
  • Which Dialog proposal the comment belongs to?
  • Should we add a delete option from this page?

@rimi-itk rimi-itk marked this pull request as ready for review November 24, 2025 08:33
@rimi-itk rimi-itk force-pushed the feature/anonymous-edit branch from 0026ea9 to aeb0b7a Compare November 24, 2025 08:35
@rimi-itk rimi-itk changed the title WIP: Added hoeringsportal_anonymous_edit module Added hoeringsportal_anonymous_edit module Nov 24, 2025
# Conflicts:
#	web/modules/custom/hoeringsportal_dialogue/hoeringsportal_dialogue.info.yml
@rimi-itk rimi-itk force-pushed the feature/anonymous-edit branch from aeb0b7a to d864868 Compare November 24, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants