Skip to content

Conversation

@rimi-itk
Copy link
Contributor

@rimi-itk rimi-itk commented Aug 28, 2025

Link to ticket

https://leantime.itkdev.dk/_#/tickets/showTicket/5282

Description

  • Updates ITK Dev project template
  • Upgrades to Symfony 7.3
  • Updates to PHP 8.4

Screenshot of the result

If your change affects the user interface you should include a screenshot of the result with the pull request.

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

If you have any further comments or questions for the reviewer please add them here.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.94%. Comparing base (8842f50) to head (a461f3b).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
src/DataFixtures/EventFixture.php 0.00% 13 Missing ⚠️
src/DataFixtures/FeedFixtures.php 0.00% 9 Missing ⚠️
src/DataFixtures/DailyOccurrenceFixture.php 0.00% 2 Missing ⚠️
src/Service/Indexing/AbstractIndexingElastic.php 0.00% 2 Missing ⚠️
src/DataFixtures/LocationFixture.php 0.00% 1 Missing ⚠️
src/DataFixtures/OccurrenceFixture.php 0.00% 1 Missing ⚠️
src/DataFixtures/OrganizationFixtures.php 0.00% 1 Missing ⚠️
src/DataFixtures/TagsFixtures.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             develop     #70      +/-   ##
============================================
+ Coverage       0.57%   3.94%   +3.37%     
  Complexity      1205    1205              
============================================
  Files            156     156              
  Lines           4361    4361              
============================================
+ Hits              25     172     +147     
+ Misses          4336    4189     -147     
Flag Coverage Δ
8.4 ?
unittests 3.94% <0.00%> (+3.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rimi-itk rimi-itk force-pushed the feature/symfony-7-php-8.4 branch from 7d07af5 to e0c674d Compare August 28, 2025 08:38
@rimi-itk rimi-itk force-pushed the feature/symfony-7-php-8.4 branch from e0c674d to cef5d06 Compare August 28, 2025 08:40
@rimi-itk rimi-itk force-pushed the feature/symfony-7-php-8.4 branch 2 times, most recently from a98ba75 to a67ac22 Compare August 28, 2025 08:44
@rimi-itk rimi-itk force-pushed the feature/symfony-7-php-8.4 branch from a67ac22 to c9a5e43 Compare August 28, 2025 08:55
@rimi-itk rimi-itk force-pushed the feature/symfony-7-php-8.4 branch from 9fdc56e to a461f3b Compare August 28, 2025 10:32
@rimi-itk rimi-itk marked this pull request as ready for review August 28, 2025 10:37
@rimi-itk rimi-itk requested a review from turegjorup August 28, 2025 10:37
@rimi-itk rimi-itk merged commit 87162a0 into develop Sep 2, 2025
12 checks passed
@rimi-itk rimi-itk deleted the feature/symfony-7-php-8.4 branch September 2, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants