feat: modem restart detection via error counter reset (#60)#253
Merged
feat: modem restart detection via error counter reset (#60)#253
Conversation
- Per-channel: evaluate each counter family independently instead of skipping the entire channel when one counter is None. (corr=None, uncorr=5) -> (None, 0) now correctly detected as declining. - Summary sanity check: only enforce when all four total values are present. Missing keys no longer default to 0 (which caused false positives on incomplete analyzer output). - Added 3 new tests for partial None and missing summary scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detects modem restarts by observing per-channel DOCSIS error counter resets between consecutive polling cycles. Emits
modem_restart_detectedevent to Event Log._check_restart()in EventDetector, before_check_errors()Test plan