Skip to content

Review the use of readability and articlebody #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nleush merged 3 commits into from
Nov 14, 2025
Merged

Review the use of readability and articlebody #606

nleush merged 3 commits into from
Nov 14, 2025

Conversation

@iparamonau
Copy link
Member

@iparamonau iparamonau commented Nov 12, 2025 •
edited
Loading

Demo link and screenshot

Link: engadget.com/....

Screenshot:
image

About the changes

  • Bug fix (non-breaking change which fixes an issue)
  • Changes to existing functionality (improvements or deprecations)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Tests and chores (up)

What has changed

  • Reviewing the use of the legacy Readability parser and linking it to a feature flag
  • Extending the conditions when Readability is invoked
  • Reviewing LD articlebody and introducing it's use in lieu of Readability where appropriate
  • Refactoring and better structure for data code dependencies

@iparamonau iparamonau requested a review from nleush November 12, 2025 22:21
nleush
nleush previously approved these changes Nov 13, 2025
View reviewed changes
@iparamonau iparamonau changed the title review the use of readability and articlebody Review the use of readability and articlebody Nov 13, 2025
@nleush nleush merged commit 70488dc into dev Nov 14, 2025
1 check passed
@nleush nleush deleted the review/readability branch November 14, 2025 15:20
nleush pushed a commit that referenced this pull request Nov 17, 2025
@iparamonau @nleush
Review the use of readability and articlebody (#606)
bff11d5 
* review the use of readability and articlebody

* fix conditions

* validate that articlebody is not empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nleush nleush nleush approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iparamonau @nleush