Skip to content

cf: include more detail with "No matching files found for mod" error #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025
Merged

cf: include more detail with "No matching files found for mod" error #555

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c15b5b5
cf: include more detail with "No matching files found for mod" error
itzg Apr 30, 2025
10df151
Tweak log and exception message
itzg Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/main/java/me/itzg/helpers/curseforge/CurseForgeApiClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,10 +181,13 @@ public CurseForgeFile resolveModpackFile(
(fileMatcher == null || file.getFileName().contains(fileMatcher)))
.findFirst()
.orElseThrow(() -> {
log.debug("No matching files trying fileMatcher={} against {}", fileMatcher,
mod.getLatestFiles()
log.debug("No matching files for mod id={} name={} trying fileMatcher={}, sample of latest files={}",
mod.getId(), mod.getName(),
fileMatcher, mod.getLatestFiles()
);
return new GenericException(String.format("No matching files found for mod '%s' (%d) using fileMatcher '%s'",
mod.getSlug(), mod.getId(), fileMatcher)
);
return new GenericException("No matching files found for mod");
});
}

Expand Down