Add Modrinth project files support #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the same syntax as curseforge (@/path/to/modrinth-mods.txt)
itzg
reviewed
Jun 19, 2025
Owner
itzg
left a comment
itzg
left a comment
There was a problem hiding this comment.
Thanks!
Just need to investigate the unit test failure.
Contributor
Author
|
It was a stubs issue with the test failure, I think I fixed it. |
Owner
|
Still failing. Please make sure you're running tests locally before pushing such as with |
Contributor
Author
|
Figured out the issue and tests pass when running locally for me. Sorry for the back and forth on this 😭 |
fireph
commented
Jun 19, 2025
src/test/java/me/itzg/helpers/modrinth/ModrinthCommandTest.java
Outdated
Show resolved
Hide resolved
itzg
reviewed
Jun 21, 2025
src/test/java/me/itzg/helpers/modrinth/ModrinthCommandTest.java
Outdated
Show resolved
Hide resolved
Owner
|
Now released in https://github.com/itzg/mc-image-helper/releases/tag/1.45.0 Can bump the version at As part of itzg/docker-minecraft-server#3506 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the same syntax as Curseforge:
@/path/to/modrinth-mods.txt. Added tests to make sure it is working as expected. I tried to follow how it was done for Curseforge as closely as possible to keep things consistent. I will make a separate PR to update the docs at itzg/docker-minecraft-server/docs/mods-and-plugins/modrinth.mddocs PR: itzg/docker-minecraft-server#3506