Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a Helm rendering issue that caused perpetual ArgoCD out-of-sync diffs when dual-stack-related Service fields were left unset (the default), aligning the rendered manifest with how Kubernetes omits unset optional fields.
Changes:
- Conditionally render
spec.ipFamiliesonly whenminecraftServer.ipFamiliesis provided. - Conditionally render
spec.ipFamilyPolicyonly whenminecraftServer.ipFamilyPolicyis provided. - Bump the chart version to
5.1.2.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/minecraft/templates/minecraft-svc.yaml | Wraps optional dual-stack Service fields in if blocks to avoid emitting empty values that trigger ArgoCD diffs. |
| charts/minecraft/Chart.yaml | Increments chart version for the bugfix release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #284