Refactor #96
Open
Refactor #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: replace jest with node own test runner, with fallback solution * runn tests on pull_request * smarter * set fail-fast to false
* improve code * integrate more * make tests pass * format files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this has merge conflicts. But I worked on it like a month ago.
As you can see it is a very different approach.
It is basically a major release.
As npm csv2json package got a security fix two days ago, i have less pressure on switching the package.
I still think, that the other csv2json package is too big. Also having lodash as dependency is a joke...
Probably we could improve the performance further and make it even smalled.