check domain configuration before starting Invidious #5352
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamantazFox
requested changes
Jun 21, 2025
src/invidious/config.cr
Outdated
|
|
||
| # Check if the domain configuration is valid | ||
| if (domain = config.domain).nil? || domain.empty? | ||
| puts "Config: 'domain' is required/can't be empty" |
Member
There was a problem hiding this comment.
domain can be empty on local instances.
Co-authored-by: Samantaz Fox <[email protected]>
SamantazFox
reviewed
Sep 13, 2025
src/invidious/config.cr
Outdated
| exit(1) | ||
| elsif parsed_domain = URI.parse(domain) | ||
| if domain != parsed_domain.domain | ||
| puts "Config: 'domain' is invalid. |
Member
There was a problem hiding this comment.
Suggested change
| puts "Config: 'domain' is invalid. | |
| puts "Config: 'domain' is invalid." |
SamantazFox
reviewed
Sep 13, 2025
src/invidious/config.cr
Outdated
| end | ||
|
|
||
| # Check if the domain configuration is valid | ||
| if (domain = config.domain).nil? || domain.empty? |
Member
There was a problem hiding this comment.
By the way you can use String.presence instead of a separate nil/empty check
Suggested change
| if (domain = config.domain).nil? || domain.empty? | |
| if !config.domain.presence |
Member
|
@Fijxu could you check @SamantazFox reviews :)? |
Member
Author
|
I did something more complicated while testing but this seems to be enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5351