Fix last character disappearance if emoji are in comment#5587
Open
shiny-comic wants to merge 1 commit intoiv-org:masterfrom
Open
Fix last character disappearance if emoji are in comment#5587shiny-comic wants to merge 1 commit intoiv-org:masterfrom
shiny-comic wants to merge 1 commit intoiv-org:masterfrom
Conversation
Fijxu
requested changes
Feb 16, 2026
SamantazFox
reviewed
Feb 26, 2026
shiny-comic
force-pushed
the
fix-comment-with-emoji
branch
2 times, most recently
from
a96de72 to
490a0b7
Compare
Previous code use UTF-8 to count characters however Emojis are UTF-16 units. This difference leads to misalignment of index offsets.
shiny-comic
force-pushed
the
fix-comment-with-emoji
branch
from
490a0b7 to
9209b21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #5503