Skip to content

player: Use correct time parameter for YouTube embed redirects #5660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
radmorecameron wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −3
Open

player: Use correct time parameter for YouTube embed redirects #5660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions assets/js/player.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,14 +104,15 @@ if (video_data.params.quality === 'dash') {
*
* @param {String} url
* @param {String} [base]
* @param {'t' | 'start'} param
* @returns {URL} urlWithTimeArg
*/
function addCurrentTimeToURL(url, base) {
function addCurrentTimeToURL(url, base, param = 't') {
var urlUsed = new URL(url, base);
urlUsed.searchParams.delete('start');
var currentTime = Math.ceil(player.currentTime());
if (currentTime > 0)
urlUsed.searchParams.set('t', currentTime);
urlUsed.searchParams.set(param, currentTime);
else if (urlUsed.searchParams.has('t'))
urlUsed.searchParams.delete('t');
return urlUsed;
Expand Down Expand Up @@ -147,7 +148,7 @@ player.on('timeupdate', function () {
let elem_yt_embed = document.getElementById('link-yt-embed');
if (elem_yt_embed) {
let base_url_yt_embed = elem_yt_embed.getAttribute('data-base-url');
elem_yt_embed.href = addCurrentTimeToURL(base_url_yt_embed);
elem_yt_embed.href = addCurrentTimeToURL(base_url_yt_embed, undefined, 'start');
}
}

Expand Down