Skip to content

Generate thumbnails of subscribed playlists (related: #4015)#5666

Open
shiny-comic wants to merge 4 commits intoiv-org:masterfrom
shiny-comic:generate-thumbs-of-subbed-playlists
Open

Generate thumbnails of subscribed playlists (related: #4015)#5666
shiny-comic wants to merge 4 commits intoiv-org:masterfrom
shiny-comic:generate-thumbs-of-subbed-playlists

Conversation

@shiny-comic
Copy link
Contributor

The bug is described in #4015.
This PR enables the generation of thumbnails for newly subscribed playlists.

Note: This fix DOES NOT regenerate thumbnails of existing subscribed playlists

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes #4015 by persisting a thumbnail reference when a user subscribes to a YouTube playlist, so “Saved playlists” can render a non-gray thumbnail for newly subscribed playlists.

Changes:

  • Persist thumbnail_id on subscribed playlists at creation time.
  • Add thumbnail_id column to the playlists table (SQL schema + DB migration).
  • Remove DB ignore annotation so thumbnail_id is serialized to/from the database.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/invidious/playlists.cr Stores a derived thumbnail_id when subscribing; InvidiousPlaylist now persists this field.
src/invidious/database/migrations/0011_add_thumnail_id_to_playlists.cr Adds a migration to append thumbnail_id to public.playlists.
config/sql/playlists.sql Updates canonical schema to include thumbnail_id.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@unixfox
Copy link
Member

unixfox commented Mar 16, 2026

Thank you. Do note that for the moment unfortunately all PR with SQL migrations are blocked until we can figure out a way to handle them properly.

@unixfox unixfox added the blocked require something else first label Mar 16, 2026
@shiny-comic
Copy link
Contributor Author

@unixfox thanks for the reply. Should I close this or keep it open?

@unixfox
Copy link
Member

unixfox commented Mar 16, 2026

you can keep it opened, we plan on fixing the sql migrations one day

@shiny-comic
Copy link
Contributor Author

@unixfox OK thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked require something else first

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants