Skip to content

Remove raw iCal caching and onIcalsFetched callback; simplify iCal listener flow#807

Merged
ivan-lednev merged 1 commit intomainfrom
codex/remove-calendar-save-to-filesystem
Feb 27, 2026
Merged

Remove raw iCal caching and onIcalsFetched callback; simplify iCal listener flow#807
ivan-lednev merged 1 commit intomainfrom
codex/remove-calendar-save-to-filesystem

Conversation

@ivan-lednev
Copy link
Owner

Motivation

  • Eliminate storing and propagating raw iCal payloads through plugin settings and Redux to simplify iCal handling and reduce persisted state surface.
  • Remove the async onIcalsFetched callback and related preloaded iCal state since raw iCal caching is no longer required.
  • Clean up associated types and listeners to match the simplified iCal flow.

Description

  • Removed RawIcal/raw iCal caching from settings, types, and Redux-related code and deleted the Cache/PluginData shape from settings.ts.
  • Eliminated onIcalsFetched argument from createReactor and ReduxExtraArgument, made preloadedState optional in createReactor, and defaulted it to {} in store.ts.
  • Removed the icalsFetched listener and related handling in listener-middleware.ts and no longer preload iCal state in main.ts, including deleting code that saved raw iCals to plugin data.
  • Adjusted imports and type references throughout the codebase to drop RawIcal usages and updated variable names (initialPluginData -> initialSettings).
  • Updated tests to reflect the new flow by removing onIcalsFetched fixtures and expectations in tests/integration.test.ts and tests/store/ical.test.ts.

Testing

  • Ran the automated test suite (npm test), which includes unit and integration tests, and all tests completed successfully after the changes.
  • Updated and executed tests/integration.test.ts and tests/store/ical.test.ts, and both updated tests passed.

Codex Task

@ivan-lednev ivan-lednev merged commit 9a5410c into main Feb 27, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant