Switched library dependencies to conan; Fixed includes to start from project root #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
ubhargavtej
added a commit
to ubhargavtej/micro-service
that referenced
this pull request
Oct 3, 2020
- Fixed CMake Error in finding OpenSSL on MAC: Execute the below command export OPENSSL_ROOT_DIR=/usr/local/opt/openssl And changing the required version in the ´CMakeList.txt´ (line 18) from ´1.0.2p´ to ´1.0.2s´. - Fixed problems concerning to Boost: This issue is due to older websocketpp being incompatible with the latest version of boost. Instead of uninstalling and trying to install older version of boost library (boost 1.60 is dibbled on Homebrew), one can update the websocketpp library in cpprestsdk by making the following change the line ivanmejiarocha#18 in "build_dependencies.sh" as below `(cd $restsdkDir && git submodule update --init && git checkout tags/$RESTSDK_VERSION -b $RESTSDK_VERSION)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to change installation of library dependencies and sub-dependencies to be handled by conan. This makes cmake setup a lot smaller and less error-prone, especially when there are multiple compilers and platforms considered to be supported for developers playing around with it.
Unfortunately, I couldn't test it on macOS, but I could test it on Ubuntu bionic with gcc 7.4.
I would guess it should be also possible to have Windows (by using msvc) as a target platform right now, maybe the cmake section handling compiler flags have to be adjusted slightly (probably cleared almost). Futhermore, build instructions for conan in the documentation might be extended by "--build=missing" to get dependencies built automatically when they are not available.