Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PT-BR
Olá Ivan, tudo bem? Encontrei o seu repo como um das mais estruturados para C# com boas práticas de arquitetura. Ao tentar rodar no OSX encontrei algumas dificuldades que busquei solucionar nesse PR.
Caso essas alterações façam sentido, fique a vontade para mergear o PR.
Caso não façam e quiser me dar um feedback, será legal também!
No mais, sucesso!!
EN
Hello Ivan, how are you? I found your repository to be one of the most well-structured for C#, with good architectural practices. When trying to run it on OSX, I encountered some difficulties that I tried to address in this PR.
If these changes make sense, feel free to merge the PR.
If they don't and you'd like to provide feedback, that would be great too!
In any case, best of luck!