Open
Conversation
YushaArif99
reviewed
Oct 30, 2024
|
|
||
| # TODO: unwrap and re-wrap the kornia module if, say, it's already converted to jax and the user wants to convert it to tensorflow | ||
| # TODO: ensure that torch -> torch works fine by returning the existing module | ||
| # TODO: ensure that framework -> torch works fine by unwrapping the existing module |
There was a problem hiding this comment.
what does this point refer to exactly? for kornia, isn't source=torch always going to be the case?
Author
There was a problem hiding this comment.
this is referring to the case that a user does something like:
import kornia
kornia.set_backend("tensorflow")
kornia.set_backend("torch")
so in this case we'd need to just unwrap the module
YushaArif99
approved these changes
Oct 30, 2024
YushaArif99
left a comment
YushaArif99
left a comment
There was a problem hiding this comment.
lgtm! I guess we might need to add some additional logic to accommodate for this functionality, as you mention. But there shouldn't be any fundamental limitations here in getting this implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@hmahmood24 @YushaArif99 from Edgar's latest comment on the merged kornia PR about
kornia.set_backend, do we think something like this would work? Of course we'd have to make some changes to the tracer-transpiler to accommodate this functionality, but can you see any issues with it fundamentally?