Fix multiple analyzer issue: IDE0090, IDE0016, IDE0305, IDE0066, CA1510

Author: Nilay Vishwakarma

.editorconfig

@@ -14,3 +14,18 @@ dotnet_diagnostic.IDE0300.severity = none
 
 # IDE0028: Simplify collection initialization
 dotnet_diagnostic.IDE0028.severity = none
+
+# IDE0090: 'new' expression can be simplified
+dotnet_diagnostic.IDE0090.severity = none
+
+# IDE0016: Null check can be simplified
+dotnet_diagnostic.IDE0016.severity = none
+
+# IDE0305: Use collection expression for fluent
+dotnet_diagnostic.IDE0305.severity = none
+
+# IDE0066: Use switch expression
+dotnet_diagnostic.IDE0066.severity = none
+
+# CA1510: Use ArgumentNullException throw helper
+dotnet_diagnostic.CA1510.severity = none

example/Program.cs

@@ -9,7 +9,9 @@ class Program
 {
     static void Main()
     {
+#pragma warning disable IDE0059 // Unnecessary assignment of a value
         GenericFsm genericFsm = new GenericFsm();
+#pragma warning restore IDE0059 // Unnecessary assignment of a value
     }
 }
 

src/EnumStateMachineDefinition.cs

@@ -22,7 +22,7 @@ public class EnumStateMachineDefinition<TState, TContext> : IStateMachineDefinit
         public IEnumerable<IState> States { get; }
 
         /// <summary>
-        /// A collection of transitions between states, represented as <see cref="ITransition{TContext}"/> instances.
+        /// A collection of transitions between states, represented as <see cref="ITransition{TState, TContext}"/> instances.
         /// </summary>
         public IEnumerable<ITransition<TState, TContext>> Transitions { get; }
 

src/IStateMachineDefinition.cs

@@ -6,6 +6,7 @@
     /// <summary>
     /// Represents a definition of a state machine, which includes its states, transitions, and initial state.
     /// </summary>
+    /// <typeparam name="TState"></typeparam>
     /// <typeparam name="TContext"></typeparam>
     public interface IStateMachineDefinition<TState, TContext> where TState : struct, Enum
     {

src/TransitionRegistry.cs

@@ -7,6 +7,7 @@
     /// <summary>
     /// Represents a registry for conditions and side effects associated with transitions in a state machine.
     /// </summary>
+    /// <typeparam name="TState">State Type</typeparam>
     /// <typeparam name="TContext">Context Type</typeparam>
     public class TransitionRegistry<TState, TContext>
     {

tests/FiniteStateMachineTests.cs

@@ -22,7 +22,7 @@ public enum TicketState
             Closed
         }
 
-        private TransitionRegistry<TicketState, TicketContext> SetupRegistry()
+        private static TransitionRegistry<TicketState, TicketContext> SetupRegistry()
         {
             var registry = new TransitionRegistry<TicketState, TicketContext>();
             registry.RegisterCondition("HasAgent", ctx => ctx.IsAgentAssigned);
@@ -31,7 +31,7 @@ private TransitionRegistry<TicketState, TicketContext> SetupRegistry()
             return registry;
         }
 
-        private EnumStateMachineDefinition<TicketState, TicketContext> BuildDefinition(TransitionRegistry<TicketState, TicketContext> registry)
+        private static EnumStateMachineDefinition<TicketState, TicketContext> BuildDefinition(TransitionRegistry<TicketState, TicketContext> registry)
         {
             var builder = FiniteStateMachineBuilder<TicketState, TicketContext>.Create("Ticket")
                 .WithInitialState(TicketState.Open)