Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overall, I think your project is very comprehensive and works great as a tic-tac-toe game! However, there is some room for improvement in the user interface. I made some changes to
GameViewto make it look clearer, mainly making the window larger by default and centering the game board in the middle of the window. Additionally, I made the background of the window change depending on whose turn it is, so it is much easier to tell who has to go.There could be further improvements to improve the overall user experience of the game, such as adding buttons to restart the game in the leaderboard view, showing the timer as the game is going on, and adding more CSS styling.