Open
Conversation
… course modules and being a great simple game. However there could possibly be some changes to improve the style of life changes. For example, I made the window dimensions larger and made it so that both players must enter a valid username to play or else an error button pops up. And I proposed ideas such as making a pause timer button as well as displaying the turn of the players in a more visible place. I also believe that getting rid of blank lines would make the readability better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found your group's project to be pretty solid, covering most of the course modules and being a great simple game. However there could possibly be some changes to improve the style of life. For example, I made the window dimensions larger and made it so that both players must enter a valid username to play or else an error button pops up. Having some javadoc comments could be nice too.
I also proposed ideas and TODO comments such as making a pause timer button as well as displaying the turn of the players in a more visible place. I also believe that getting rid of blank lines would make the readability better. There's also a bit of small changes that may be nitpicky but I added as well.