Skip to content

feat(cli): support $ delimiter in resolver export names#163

Merged
izumin5210 merged 2 commits intomainfrom
izumin5210/name-delimiter2
Feb 14, 2026
Merged

feat(cli): support $ delimiter in resolver export names#163
izumin5210 merged 2 commits intomainfrom
izumin5210/name-delimiter2

Conversation

@izumin5210
Copy link
Owner

Why

Support a naming pattern where exported resolver variable names can include namespace-like prefixes separated by $ while still deriving clean GraphQL field names.

Summary

  • Add resolver export-name parsing for defineField/defineQuery/defineMutation to use the substring after the last $ as the GraphQL field name.
  • Keep the original export symbol name separately for resolver imports, so generated resolver wiring remains valid.
  • Add an error diagnostic when the export name ends with $ (empty suffix).
  • Add golden test cases for successful delimiter parsing and empty-suffix error handling.
  • Add a changeset for @gqlkit-ts/cli (minor).

Notes

  • Golden snapshots were prepared in-repo; test execution could not be completed in this environment because dependency installation failed under restricted network access.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Code Metrics Report

main (f91b8db) #163 (15032d5) +/-
Coverage 87.4% 87.4% +0.0%
Test Execution Time 9m0s 9m12s +12s
Details
  |                     | main (f91b8db) | #163 (15032d5) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          87.4% |          87.4% | +0.0% |
  |   Files             |             71 |             71 |     0 |
  |   Lines             |           4671 |           4682 |   +11 |
+ |   Covered           |           4085 |           4096 |   +11 |
- | Test Execution Time |           9m0s |          9m12s |  +12s |

Code coverage of files in pull request scope (90.3% → 90.6%)

Files Coverage +/- Status
packages/cli/src/gen-orchestrator/orchestrator.ts 98.2% 0.0% modified
packages/cli/src/resolver-extractor/extractor/define-api-extractor.ts 85.1% +0.7% modified

Reported by octocov

@izumin5210 izumin5210 merged commit 337b5b1 into main Feb 14, 2026
8 checks passed
@izumin5210 izumin5210 deleted the izumin5210/name-delimiter2 branch February 14, 2026 01:21
@github-actions github-actions bot mentioned this pull request Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant