fix(isac): correct bibliographic reference, clarify CRB model assumptions - #33
Merged
Conversation
…nd unstated assumptions Co-authored-by: j143 <53068787+j143@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CRB model parameterization and references
fix(isac): correct bibliographic reference, clarify CRB model assumptions
Mar 8, 2026
j143
marked this pull request as ready for review
March 8, 2026 19:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DFRC module cited the wrong Liu et al. paper (JSAC vs TSP) and claimed the scalar Kay SISO formula was directly equivalent to Liu's MIMO CRB — it is not. Several physical assumptions (flat spectrum, one-way range convention, orthogonal subcarrier capacity model) were also silent.
Bibliographic fix
"Cramér–Rao Bound Optimization for Joint Radar-Communication Beamforming", IEEE Trans. Signal Process. 2018, DOI10.1109/TSP.2018.2864261baselines/liu_jsac2018_crb.csv→baselines/liu_tsp2018_crb.csvrun.rs,config.json,README.md,docs/,ROADMAP.mdCRB model clarification (
dfrc.rs,liu_tsp2018_crb.csv)The formula
c² / (8π²B²γ_s)is a simplified SISO approximation (Kay eq. 3.31), not Liu et al.'s MIMO CRB (which depends on antenna count, transmit covariance, snapshot count). Constants are tuned to be numerically comparable to Table II — not derived from Liu's model.Unstated assumptions now documented
Bis used as RMS bandwidth — valid only for rectangular spectrum; OFDM shaping changes the constantR = c·τ); round-trip radar would add a factor of ¼C = B·log₂(1+γ_c)with orthogonal subcarrier assignment, no sensing-waveform reuse as data symbols💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.