Add a regression test for git commit -a index corruption#1819
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1819 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 98 98
Lines 20055 20055
=======================================
+ Hits 18395 18396 +1
+ Misses 1660 1659 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates prek’s integration test suite around git commit -a hook execution to better normalize snapshot output and to document/reproduce a currently-known failure mode involving GIT_INDEX_FILE.
Changes:
- Extend the
git_commit_asnapshot filters to normalize an additional hash value. - Add a new Unix-only regression/repro test that captures the current failure when a hook writes to a temp git index during
git commit -a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1815
closes #1786