com.jme3.anim.tween.action.BaseAction: basic javadoc #2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephengold
added
the
Documentation
Ali-RS
reviewed
May 25, 2023
jme3-core/src/main/java/com/jme3/anim/tween/action/BaseAction.java
Outdated
Show resolved
Hide resolved
pavly-gerges
commented
May 31, 2023
jme3-core/src/main/java/com/jme3/anim/tween/action/BaseAction.java
Outdated
Show resolved
Hide resolved
An assertive note about the only condition this method could be invoked from the user code.
* JavaDoc entry refinement. * Removed copied notes. * Added `@see` tags.
Contributor
Author
|
I added some refinements and simplifications. It's ready for another review. |
Contributor
Author
|
Thanks for merging this PR. I am glad my work is appreciated. I have been working on the animation system documentation for a long time, and now preparing to maintain the API by further studying the architecture involved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides basic javadoc for the class
com.jme3.anim.tween.action.BaseAction.