You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi everyone,
Thank you for identifying the backwards compatibility issue and for all your hard work. While Stephen's PR offers a great solution to preserve my proposal, adding two more methods might lead to confusion and increased maintenance in the future.
Given that my PR isn't crucial and may cause more issues than benefits, I believe the best solution in this case is to discard this PR and my PR and restores the pre-PR #2231 API of AnimComposer.
I appreciate your understanding and time. Let's continue working together to make the jme engine even better!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defectSomething that is supposed to work, but doesn't. Less severe than a "bug"
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stephengold
added
the
defect
This restores the pre-PR #2231 API of
AnimComposer, in order to improve compatibility with JME 3.7 .It then adds the 2 new methods (which return objects) under different names, to provide the functionality desired by @capdevon.