You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR was created to address issue #2370. Here's what it does:
It adds code to MotionEvent.cloneFields() to clone the path field. While implementing this change, I discovered that the lookAt and rotation fields also needed to be cloned. (The direction and upVector fields are cloned in the jmeClone() method, which is irregular but suffices for most use cases.)
It makes MotionPath and Spline deeply cloneable, adding jmeClone() and cloneFields() methods. Unfortunately, Cloner.clone() does not work on ArrayList<Float> because Float is not cloneable---see issue Cloner fails on enums and wrapped primitives #879. In Spline.cloneFields() I used copy constructors to work around this limitation.
It adds automated cloning tests for all 3 classes to jme3-core/src/test. The cloning tests for Spline use the same test splines as the existing serialization tests. To avoid duplicating code, I refactored the generation of test splines to private methods.
The copyright notices in the affected source files were updated to include the year 2025.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a work in progress.