Fix TextureArray not exporting WrapMode#2395
Merged
yaRnMcDonuts merged 5 commits intojMonkeyEngine:masterfrom Mar 20, 2025
Merged
Fix TextureArray not exporting WrapMode#2395yaRnMcDonuts merged 5 commits intojMonkeyEngine:masterfrom
yaRnMcDonuts merged 5 commits intojMonkeyEngine:masterfrom
Conversation
- Implemented write and read to include wrapS and wrapT values
stephengold
reviewed
Mar 10, 2025
jcfandino
force-pushed
the
texture-array-wrap
branch
from
0779d08 to
3154d3f
Compare
jcfandino
force-pushed
the
texture-array-wrap
branch
from
3154d3f to
91b5eee
Compare
Member
|
I made the changes that I requested in my review (with the permission of the PR author) and everything looks good. So I will plan to merge this in ~48 hours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2394